Skip to content

[TOOL-3378] Dashboard: Add Contract to Project UI updates #6233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

[TOOL-3378] Dashboard: Add Contract to Project UI updates #6233

merged 1 commit into from
Feb 14, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 11, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on refactoring and improving the structure of the dashboard application by removing obsolete files, enhancing component functionality, and updating UI elements for better user experience.

Detailed summary

  • Deleted several unused files related to contract management.
  • Updated className properties for better styling consistency.
  • Added accountAddress prop to various components for enhanced functionality.
  • Introduced new hooks and functions for managing project contracts.
  • Improved error handling in contract import functionality.
  • Enhanced UI components for better responsiveness and clarity.

The following files were skipped due to too many changes: apps/dashboard/src/components/contract-components/tables/cells.tsx, apps/dashboard/src/components/contract-components/contract-deploy-form/add-to-project-card.tsx, apps/dashboard/src/components/smart-wallets/AccountFactories/index.tsx, apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/_layout/primary-dashboard-button.tsx, apps/dashboard/src/components/contract-components/tables/contract-table.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 11, 2025

TOOL-3378 Implement "Add contract to Project" UIs

@vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 1:48am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 14, 2025 1:48am
login ⬜️ Skipped (Inspect) Feb 14, 2025 1:48am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 14, 2025 1:48am
wallet-ui ⬜️ Skipped (Inspect) Feb 14, 2025 1:48am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 11, 2025 23:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 11, 2025 23:30 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 11, 2025 23:30 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6f381d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login February 11, 2025 23:30 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 11, 2025
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title [TOOL-3378] Dashboard: Add Contract to Project UI updates [TOOL-3378] Dashboard: Add Contract to Project UI updates - DO NOT MERGE Feb 11, 2025
@MananTank MananTank marked this pull request as ready for review February 11, 2025 23:30
@MananTank MananTank requested review from a team as code owners February 11, 2025 23:30
@MananTank MananTank marked this pull request as draft February 11, 2025 23:30
@codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (0c5a51c) to head (6f381d7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6233   +/-   ##
=======================================
  Coverage   56.86%   56.86%           
=======================================
  Files        1166     1166           
  Lines       64523    64523           
  Branches     5226     5226           
=======================================
  Hits        36694    36694           
  Misses      27101    27101           
  Partials      728      728
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0c5a51c
packages 55.08% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.9 s (+34.47% 🔺) 3.8 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 5.3 s (-9.03% 🔽) 7.7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 339 ms (+77.7% 🔺) 451 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 76 ms (+11.77% 🔺) 86 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 429 ms (-21.02% 🔽) 814 ms

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 12, 2025 16:12 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 12, 2025 16:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 12, 2025 16:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 12, 2025 16:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 13, 2025 19:48 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 13, 2025 19:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 13, 2025 19:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 13, 2025 19:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 13, 2025 20:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 13, 2025 20:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 13, 2025 20:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 13, 2025 20:21 Inactive
@jnsdls jnsdls changed the title [TOOL-3378] Dashboard: Add Contract to Project UI updates - DO NOT MERGE, MIGRATION REQUIRED [TOOL-3378] Dashboard: Add Contract to Project UI updates Feb 14, 2025
@jnsdls jnsdls marked this pull request as ready for review February 14, 2025 01:40
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 14, 2025 •
edited
Loading

Merge activity

@MananTank
[TOOL-3378] Dashboard: Add Contract to Project UI updates (#6233)
6f381d7 
<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on refactoring and improving the structure of the dashboard application by removing obsolete files, enhancing component functionality, and updating UI elements for better user experience.

### Detailed summary
- Deleted several unused files related to contract management.
- Updated `className` properties for better styling consistency.
- Added `accountAddress` prop to various components for enhanced functionality.
- Introduced new hooks and functions for managing project contracts.
- Improved error handling in contract import functionality.
- Enhanced UI components for better responsiveness and clarity.

> The following files were skipped due to too many changes: `apps/dashboard/src/components/contract-components/tables/cells.tsx`, `apps/dashboard/src/components/contract-components/contract-deploy-form/add-to-project-card.tsx`, `apps/dashboard/src/components/smart-wallets/AccountFactories/index.tsx`, `apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx`, `apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/_layout/primary-dashboard-button.tsx`, `apps/dashboard/src/components/contract-components/tables/contract-table.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 14, 2025 01:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 14, 2025 01:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 14, 2025 01:41 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 14, 2025 01:41 Inactive
@graphite-app graphite-app bot merged commit 6f381d7 into main Feb 14, 2025
32 checks passed
@graphite-app graphite-app bot deleted the TOOL-3378 branch February 14, 2025 01:48
@vercel vercel bot temporarily deployed to Production – login February 14, 2025 01:48 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 14, 2025 01:48 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 14, 2025 01:48 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 14, 2025 01:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls